[3.9] bpo-28002: Roundtrip f-strings with ast.unparse better (GH-19612)#23430
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
By attempting to avoid backslashes in f-string expressions. We also now proactively raise errors for some backslashes we can't avoid while unparsing FormattedValues Co-authored-by: hauntsaninja <> Co-authored-by: Shantanu <[email protected]> Co-authored-by: Batuhan Taskaya <[email protected]> (cherry picked from commit a993e90) Co-authored-by: Shantanu <[email protected]>
Contributor
hauntsaninja commented Nov 20, 2020
@isidentical Thanks for all the reviews and helping see this change through! :-) There seems to be some issue with automerge on backports, so I think you'll need to manually merge; e.g. #22069 (comment) |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By attempting to avoid backslashes in f-string expressions.
We also now proactively raise errors for some backslashes we can't
avoid while unparsing FormattedValues
Co-authored-by: hauntsaninja <>
Co-authored-by: Shantanu [email protected]
Co-authored-by: Batuhan Taskaya [email protected]
(cherry picked from commit a993e90)
Co-authored-by: Shantanu [email protected]
https://bugs.python.org/issue28002
Automerge-Triggered-By: GH:isidentical