Skip to content

bpo-41818: test_master_read() in test_pty.py should be expected to fail on every platform that is not Linux; that includes Solaris.#23533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
8vasu wants to merge 2 commits into from
Closed

bpo-41818: test_master_read() in test_pty.py should be expected to fail on every platform that is not Linux; that includes Solaris. #23533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfb839b
test_master_read() in test_pty.py should be expected to fail
8vasu Nov 27, 2020
bc676f6
📜🤖 Added by blurb_it.
blurb-it[bot] Nov 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions Lib/test/test_pty.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -82,9 +82,8 @@ def expectedFailureIfStdinIsTTY(fun):
pass
return fun

def expectedFailureOnBSD(fun):
PLATFORM = platform.system()
if PLATFORM.endswith("BSD") or PLATFORM == "Darwin":
def expectedFailureIfNotLinux(fun):
if platform.system() != "Linux":
return unittest.expectedFailure(fun)
return fun

Expand DownExpand Up@@ -314,7 +313,7 @@ def test_fork(self):

os.close(master_fd)

@expectedFailureOnBSD
@expectedFailureIfNotLinux
def test_master_read(self):
debug("Calling pty.openpty()")
master_fd, slave_fd = pty.openpty()
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2020-11-27-21-46-54.bpo-41818.IXmYhQ.rst
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
Change expectedFailureOnBSD() to expectedFailureIfNotLinux() in test_pty.py because test_master_read() should be expected to fail on every platform that is not Linux; that includes Solaris.