Add symbols of the stable ABI to python3dll.c#23598
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
vstinner commented Dec 1, 2020
Member
markshannon commented Dec 1, 2020
Can we please stop exposing There is no way to prevent race conditions when used from without the GIL held. The lifetime of a |
MemberAuthor
I guess that you are talking about bpo-39947. Functions are added to the limited C API in Python 3.9. The purpose of this issue is to make the PyThreadState structure opaque, currently C extensions access directly PyThreadState members. I suggest you to discuss on bpo-39947 directly. This issue is only about fixing the Windows implementation for the stable ABI. |
Contributor
ZackerySpytz commented Dec 1, 2020
I like this PR, but GH-23415 is already open for the addition of |
Member
alex commented Dec 15, 2020
Are these already exposed in the headers with |
MemberAuthor
vstinner commented Dec 16, 2020
This PR doesn't move any function to the stable ABI. They are already part of the stable API. This PR only fix the Windows implementation of the stable ABI. |
alex approved these changes Dec 16, 2020
Member
alex left a comment
alex left a comment There was a problem hiding this comment.
We really need to find a way to make sure we're not constantly leaving windows abi3 in a broken state.
MemberAuthor
vstinner commented Dec 16, 2020
@alex: "We really need to find a way to make sure we're not constantly leaving windows abi3 in a broken state." Pablo is working on a Linux tool for that: Tools/scripts/stable_abi.py It shouldn't be too hard to check that Doc/data/stable_abi.dat and PC/python3dll.c are kept in sync (in the "Tests / Check if generated files are up to date" CI job). |
Member
alex commented Dec 16, 2020 via email
Wonderful! …On Wed, Dec 16, 2020 at 9:08 AM Victor Stinner ***@***.***> wrote: @alex <https://github.com/alex>: "We really need to find a way to make sure we're not constantly leaving windows abi3 in a broken state." Pablo is working on a Linux tool for that: Tools/scripts/stable_abi.py It shouldn't be too hard to check that Doc/data/stable_abi.dat and PC/python3dll.c are kept in sync (in the "Tests / Check if generated files are up to date" CI job). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#23598 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAGBBZGBK24C6RYD5TVP3SVC5MZANCNFSM4UJE7ZSQ> . -- All that is necessary for evil to succeed is for good people to do nothing. |
MemberAuthor
vstinner commented Dec 16, 2020
I manually backported the change to 3.9 which uses a different format for the Windows stable ABI: PR #23801. |
bedevere-bot commented Dec 16, 2020
|
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Add the following symbols to python3dll.c: * PyFrame_GetCode (bpo-40421) * PyFrame_GetLineNumber (bpo-40421) * PyModule_AddObjectRef (bpo-1635741) * PyObject_CallNoArgs (bpo-37194) * PyThreadState_GetFrame (bpo-39947) * PyThreadState_GetID (bpo-39947) * PyThreadState_GetInterpreter (bpo-39947)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the following symbols to python3dll.c: