[3.9] bpo-42532: Check if NonCallableMock's spec_arg is not None instead of call its __bool__ function (GH-23613)#23676
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ead of call its __bool__ function (GH23613) Check if NonCallableMock's spec_arg is not None instead of call its __bool__ function (cherry picked from commit c598a04) Co-authored-by: idanw206 <31290383+idanw206@users.noreply.github.com>
cjw296 approved these changes Dec 7, 2020
Contributor
idanw206 commented Dec 7, 2020
Thanks for the backport! Looking forward for this to be released! |
Contributor
idanw206 commented Dec 13, 2020
@tirkarthi@cjw296 Can one of you guys merge it? Thanks! |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check if NonCallableMock's spec_arg is not None instead of call its bool function
(cherry picked from commit c598a04)
Co-authored-by: idanw206 31290383+idanw206@users.noreply.github.com
https://bugs.python.org/issue42532