Skip to content

Conversation

@aeros
Copy link
Contributor

@aerosaeros commented Dec 10, 2020

As per PEP 594, this PR removes asyncore, asynchat, and smptd. This includes any documentation, tests, and source code, except for parts that were needed for existing tests. Those were moved to Lib/test/support/<module>, and the essential parts were determined through usage of coverage.py. After I removed test_<module>, I looked to see which members were utilized in the existing tests, and removed any that were not used. I did not do any partial removals though; e.g. specific unused branches within a member that is otherwise used. I also left unused __repr__ for debugging purposes.

For improved communication and convenience to users, importing any of the 3 removed modules after these changes results in the following:

raiseImportError( "As of 3.10, <module> has been removed from the standard library, see ""PEP 594 for details. An archived (no longer maintained) version exists ""at https://github.com/tiran/legacylib" )

This could potentially be removed in couple versions if needed, but since it imposes no real maintenance burden I think we can leave the custom ImportError indefinitely. The only change would possibly be updating tiran/legacylib to python/legacylib, assuming it is eventually moved there.

https://bugs.python.org/issue42611

@aerosaeros requested a review from tiranDecember 10, 2020 04:40
@aerosaeros changed the title PEP 594 - Remove asyncore, asynchat, and smptd from stdlibbpo-42611: PEP 594 - Remove asyncore, asynchat, and smptd from stdlibDec 10, 2020
@aerosaeros marked this pull request as ready for review December 10, 2020 05:52
@aerosaeros requested review from a team and vsajip as code ownersDecember 10, 2020 05:52
@aerosaeros removed request for a team and vsajipDecember 10, 2020 06:22
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsbot added the stale Stale PR or inactive for long period of time. label Jan 18, 2021
@tirantiran removed their request for review December 7, 2021 12:07
@hugovk
Copy link
Member

hugovk commented Apr 11, 2022

@github-actionsgithub-actionsbot removed the stale Stale PR or inactive for long period of time. label Aug 2, 2022
@iritkatriel
Copy link
Member

Closing as out of date.

This PR was superseded by #72719 (which was reverted and will not be superseded by yet a new one).

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@aeros@hugovk@iritkatriel@the-knights-who-say-ni@ezio-melotti@bedevere-bot