bpo-35134: Add Include/cpython/pytime.h file

[nw0]

Add Include/cpython/pytime.h header file.

Move CPython C API from Include/pytime.h into a new
Include/cpython/pytime.h header file, which is included by
Include/pytime.h.

https://bugs.python.org/issue35134

In the same vein as previous PRs by @vstinner. I've never done this before, so apologies in advance if I've messed anything up.

https://bugs.python.org/issue35134

[nw0]

Hmm, I'd like to add the skip-news label like previous PRs for this issue, but can't seem to do this. Help?

[vstinner]

Hum, since the new Include/pytime.h is basically empty. I suggest to leave the file unchanged and the move it into Include/cpython/.

I don't expect anyone to include it directly, and it's already included by "Python.h". The C API documentation asks to only include "Python.h."

[vstinner]

Hum. Since it's included by Python.h, including it explicitly is not needed, no?

[nw0]

I've updated these, and moved the pytime.h include further down in Python.h to allow for it. I believe there aren't any other files including pytime.h directly now.

[vstinner]

I don't think that people should include pytime.h directly, and so I suggest to simply remove these includes. Let people respect the Python C API documentation which suggests to only include "Python.h".

[vstinner]

Thank you, I merged your PR.

[bedevere-bot]

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL8 LTO 3.x has failed when building commit 17dbd40.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/361/builds/1230) and take a look at the build logs.
4. Check if the failure is related to this commit (17dbd40) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/361/builds/1230

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

412 tests OK.

10 slowest tests:

• test_peg_generator: 4 min 37 sec
• test_concurrent_futures: 2 min 46 sec
• test_gdb: 2 min 38 sec
• test_multiprocessing_spawn: 1 min 36 sec
• test_tokenize: 1 min 12 sec
• test_unparse: 1 min 6 sec
• test_multiprocessing_forkserver: 1 min 4 sec
• test_asyncio: 1 min 3 sec
• test_lib2to3: 1 min 3 sec
• test_multiprocessing_fork: 54.1 sec

1 test altered the execution environment:
test_asyncio

13 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_ossaudiodev
test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
test_winreg test_winsound test_zipfile64

Total duration: 5 min 42 sec

Click to see traceback logs

Traceback (most recent call last): File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/asyncio/sslproto.py", line 321, in __del__self.close() File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/asyncio/sslproto.py", line 316, in closeself._ssl_protocol._start_shutdown() File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/asyncio/sslproto.py", line 590, in _start_shutdownself._abort() File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/asyncio/sslproto.py", line 731, in _abortself._transport.abort() File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/asyncio/selector_events.py", line 680, in abortself._force_close(None) File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/asyncio/selector_events.py", line 731, in _force_closeself._loop.call_soon(self._call_connection_lost, exc) File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/asyncio/base_events.py", line 745, in call_soonself._check_closed() File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/asyncio/base_events.py", line 510, in _check_closedraiseRuntimeError('Event loop is closed') RuntimeError: Event loop is closed