bpo-40077: Add traverse/clear/free to arraymodule#24066
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ContributorAuthor
erlend-aasland commented Jan 2, 2021
@encukou, would you mind reviewing this? |
shihai1991 approved these changes Jan 3, 2021
Member
shihai1991 left a comment
shihai1991 left a comment There was a problem hiding this comment.
LGTM.
Just a nitpick: PyObject *m--> PyObject *module or PyObject *mod would be more exact.
ContributorAuthor
erlend-aasland commented Jan 3, 2021
I agree. I'll fix it. |
Member
encukou commented Jan 3, 2021
Thank you! |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue40077