Skip to content

Conversation

@JulienPalard
Copy link
Member

@JulienPalardJulienPalard commented Jan 4, 2021

@JulienPalard
Copy link
MemberAuthor

Hum no, a full revert is not needed, only some bits has to be reverted, let me check this in details.

…GH-23658)" This partially reverts commit e89993c, which was removing backslashes in documentations compiled with Sphinx < 3, used for Python 3.8 and 3.9 docs.
@JulienPalardJulienPalardforce-pushed the revert-23827-backport-dcc997c-3.9 branch from 946dfdd to b806721CompareJanuary 4, 2021 12:46
@JulienPalard
Copy link
MemberAuthor

I kept only backslashes involved in strings, which looks to be the only one causing troubles.

@JulienPalardJulienPalard changed the title Revert "[3.9] [doc] Fix erroneous backslashes in signatures and names (GH-23658)"bpo-42822: Revert "[3.9] [doc] Fix erroneous backslashes in signatures and names (GH-23658)"Jan 4, 2021
@JulienPalardJulienPalard changed the title bpo-42822: Revert "[3.9] [doc] Fix erroneous backslashes in signatures and names (GH-23658)"[3.9] bpo-42822: Revert "[3.9] [doc] Fix erroneous backslashes in signatures and names (GH-23658)"Jan 4, 2021
Copy link
Contributor

@andresdelfinoandresdelfino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JulienPalardJulienPalard merged commit e6d0107 into 3.9Jan 4, 2021
@JulienPalardJulienPalard deleted the revert-23827-backport-dcc997c-3.9 branch January 4, 2021 16:19
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dirskip issueskip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@JulienPalard@andresdelfino@the-knights-who-say-ni@bedevere-bot