Skip to content

bpo-1635741: Adapt _multibytecodec to multi-phase initialization#24095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 17 commits into from
Jan 4, 2021
Merged

bpo-1635741: Adapt _multibytecodec to multi-phase initialization #24095

vstinner merged 17 commits into from
Jan 4, 2021

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commented Jan 4, 2021•
edited by bedevere-bot
Loading

  • Establish module state
  • Convert types to heap types and add them to module state
  • Add multi-phase init support

https://bugs.python.org/issue1635741

@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commented Jan 4, 2021

@corona10 or @shihai1991, would one of you mind reviewing this PR?

shihai1991
shihai1991 reviewed Jan 4, 2021
View reviewed changes
Copy link
Member

@shihai1991shihai1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. just nitpicks in here. And no refleaks when I run ./python -m test test_multibytecodec -R 3:3 -vv.

vstinner
vstinner reviewed Jan 4, 2021
View reviewed changes
@erlend-aaslanderlend-aaslandforce-pushed the multibytecodec-module-state branch from 90deaf4 to e8b3021CompareJanuary 4, 2021 20:55
@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commented Jan 4, 2021

Thanks for your review, @vstinner. PTAL.

vstinner
vstinner reviewed Jan 4, 2021
View reviewed changes
Erlend Egeberg Aaslandand others added 2 commits January 4, 2021 22:08
@vstinner
Rename __methods to _multibytecodec_methods for consistency
18c1829
Co-authored-by: Victor Stinner <vstinner@python.org>
Fix rename
bf3da94
@vstinnervstinner merged commit 0b858cd into python:masterJan 4, 2021
@vstinner
Copy link
Member

vstinner commented Jan 4, 2021

Merged, thanks.

@erlend-aaslanderlend-aasland deleted the multibytecodec-module-state branch January 4, 2021 21:37
@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commented Jan 4, 2021

Merged, thanks.

Great, thanks for a thorough review!

@neoneneneonene mentioned this pull request Jan 8, 2021
Merged
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@adorilson
bpo-1635741: Convert _multibytecodec to multi-phase init (pythonGH-24095
42e5f6b
) Convert the _multibytecodec extension module (CJK codecs) to multi-phase initialization (PEP 489).
@kylotankylotanmannequin mentioned this pull request Sep 19, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10corona10Awaiting requested review from corona10

@encukouencukouAwaiting requested review from encukou

@shihai1991shihai1991Awaiting requested review from shihai1991

@vstinnervstinnerAwaiting requested review from vstinner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erlend-aasland@vstinner@shihai1991@the-knights-who-say-ni@bedevere-bot