Skip to content

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commented Jan 4, 2021

Remove code required to support SQLite pre 3.7.15.

https://bugs.python.org/issue40810

@erlend-aasland
Copy link
ContributorAuthor

@berkerpeksag Would you mind reviewing this?

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, SQLite 3.7.15 was released 8 years ago, so I think we are safe to bump the minimal required version. But please wait for confirmation of other core developer.

Remove code required to support SQLite pre 3.7.15.
@erlend-aasland
Copy link
ContributorAuthor

Thanks, @serhiy-storchaka! If you've got a suggestion for another core dev that'd be interested in reviewing this, please feel free to request their review.

FYI, rebased onto master for the #24110 NEWS item fix.

@erlend-aasland
Copy link
ContributorAuthor

@pablogsal Would you mind reviewing this? (Ref. your review of #20909)

Copy link
Member

@berkerpeksagberkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd prefer stick to 3.7.15 for a while. I feel like we are getting a bit carried away with dropping support for older SQLite versions :)

@berkerpeksagberkerpeksag merged commit cf0b239 into python:masterJan 6, 2021
@erlend-aasland
Copy link
ContributorAuthor

LGTM, but I'd prefer stick to 3.7.15 for a while. I feel like we are getting a bit carried away with dropping support for older SQLite versions :)

Sure, I agree :) There's not too much support code laying around now, so I think we can stay at 3.7.15 for now. Thanks.

@erlend-aaslanderlend-aasland deleted the require-sqlite-3.7.15 branch January 6, 2021 00:08
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Feb 24, 2021
SQLite 3.7.15 is required as by pythonGH-24106. SQLITE_OPEN_URI was added in SQLite 3.7.7.
berkerpeksag pushed a commit that referenced this pull request Feb 26, 2021
SQLite 3.7.15 is required as by GH-24106. SQLITE_OPEN_URI was added in SQLite 3.7.7.
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
SQLite 3.7.15 is required as by pythonGH-24106. SQLITE_OPEN_URI was added in SQLite 3.7.7.
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Jun 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@erlend-aasland@berkerpeksag@serhiy-storchaka@the-knights-who-say-ni@bedevere-bot