Skip to content

Conversation

@encukou
Copy link
Member

@encukouencukou commented Jan 5, 2021

When stdin is a TTY, the test added in commit c13d899
is expected to fail. However, when it failed, it did not close
its file descriptors. This is flagged by the refleak tests (but
only when stdin is a TTY, which doesn't seem to be the case on CI).

https://bugs.python.org/issue41818

When stdin is a TTY, the test added in commit c13d899 is expected to fail. However, when it failed, it did not close its file descriptors. This is flagged by the refleak tests (but only when stdin is a TTY, which doesn't seem to be the case on CI).
@encukou

This comment has been minimized.

@8vasu
Copy link
Contributor

8vasu commented Jan 5, 2021

@encukou can you please check my request in the python issue?

@encukou
Copy link
MemberAuthor

The comment there was:

That test was created by modifying an existing test which already had that issue; it is documented in a comment by user nnorwitz in the file. If your solution resolves the problem for all the tests in "class PtyTest", then can you please also remove that comment?

I'm not that concerned about failing tests leaking – leak checks are run with the tests, so if tests fail, leaking doesn't really matter.
But test_openpty is sometimes expected to fail, and in that case, the test suite succeeded but leaked.

Anyway, I've modified the other tests and removed the comment.

@zwarezware added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 12, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @zware for commit 494fd7b 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 12, 2021
@encukou
Copy link
MemberAuthor

encukou commented Jan 19, 2021

There's a failure in test_curses, test timeout in test_asyncio, and ... a BuildBot error, it seems.
bpo-41701 makes these issues quite hard to investigate, but it looks like they're not related to this PR.

@encukouencukou merged commit 65cf1ad into python:masterJan 19, 2021
@encukouencukou deleted the pty_refleak branch January 19, 2021 13:03
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
When stdin is a TTY, the test added in commit c13d899 is expected to fail. However, when it failed, it did not close its file descriptors. This is flagged by the refleak tests (but only when stdin is a TTY, which doesn't seem to be the case on CI).
@8vasu8vasumannequin mentioned this pull request May 5, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@encukou@8vasu@bedevere-bot@zware@the-knights-who-say-ni