gh-63882: Adds tests for xml.dom.minidom#24152
Uh oh!
There was an error while loading. Please reload this page.
Conversation
id in the _repr_ method doesn't seem that useful when sending back a NodeList Adds also docstrings to some methods.
it also removes the old tests so we get more regular tests
Removes the old tests. Adds new tests in a regular form and testing more cases Adds docstring
These tests are useless for now. We will be adding them again later with proper code.
Some parts of the function were not tested. This is fixing it.
* Convert old tests to have a regular form * Adds new tests to cover more cases.
* Adds tests for removeChild * Remove old tests * Fix the docstring for removeChild and replaceChild
This PR is stale because it has been open for 30 days with no activity. |
terryjreedy changed the title 
The merge conflict is a result of new imports for pyexpat and parsers...ExpatError in main. I could easily fix the conflict, but I really do not like putting multiple imports from one module in separate lines and would undo an revise that change also at the same time. |
terryjreedy commented Nov 29, 2022
I consider this unreviewable until split into multiple PRs. See #63882 (comment) |
karlcow commented Nov 29, 2022
I can't work on this anymore. Unfortunately. |
terryjreedy commented Jan 5, 2025
@karlcow Thank you for this draft. The docstring additions have been moved to a new issue #128508 and PR #128477 for revisions. You are listed on the latter as a co-author. The empty tests should be commented out until replaced, not removed. A new PR should close the issue. The revised tests, fixing names and code, should be moved to another new issue. With this is done, the tests for class methods should be put in separate TestCase classes. MinidomTest should only have the module function tests. |
5 participants
This is a work in progress not yet ready for review.
https://bugs.python.org/issue19683