Skip to content

bpo-40170: Convert PyDescr_IsData macro to C function#24535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 5 commits into from
Feb 16, 2021
Merged

bpo-40170: Convert PyDescr_IsData macro to C function #24535

vstinner merged 5 commits into from
Feb 16, 2021

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commented Feb 15, 2021•
edited by bedevere-bot
Loading

The macro accessed the PyTypeObject.tp_descr_set member.
Reimplemented as a C function to hide implementation details.

https://bugs.python.org/issue40170

@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commented Feb 15, 2021

@vstinner Would you mind reviewing this?

vstinner
vstinner reviewed Feb 15, 2021
View reviewed changes
vstinner
vstinner approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commented Feb 16, 2021

Thanks, @vstinner!

@vstinnervstinner merged commit 871eb42 into python:masterFeb 16, 2021
@erlend-aaslanderlend-aasland deleted the bpo-40170/PyDescr_IsData branch February 16, 2021 08:32
@erlend-aaslanderlend-aasland mentioned this pull request Feb 16, 2021
Merged
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Feb 17, 2021
MovepythonGH-24533,pythonGH-24535, andpythonGH-24548NEWS entries …
c794f9c
…to "C API" section
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@adorilson
bpo-40170: Convert PyDescr_IsData() to static inline function (python…
b415fbd
…GH-24535)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukouencukouencukou left review comments

@vstinnervstinnervstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erlend-aasland@vstinner@encukou@the-knights-who-say-ni@bedevere-bot