Skip to content

bpo-43588: fix boolobject.c static variables under building under building Python with --with-experimental-isolated-subinterpreters may cause crash#24966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JunyiXie wants to merge 1 commit into from
Closed

bpo-43588: fix boolobject.c static variables under building under building Python with --with-experimental-isolated-subinterpreters may cause crash #24966

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions Objects/boolobject.c
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,22 +4,25 @@
#include "longintrepr.h"

/* We define bool_repr to return "False" or "True" */

static PyObject *false_str = NULL;
static PyObject *true_str = NULL;

static PyObject *
bool_repr(PyObject *self)
{
_Py_IDENTIFIER(True);
_Py_IDENTIFIER(False);

PyObject *s;

if (self == Py_True)
s = true_str ? true_str :
(true_str = PyUnicode_InternFromString("True"));
else
s = false_str ? false_str :
(false_str = PyUnicode_InternFromString("False"));
Py_XINCREF(s);
{
s = _PyUnicode_FromId(&PyId_True); // borrowed ref
} else{
s = _PyUnicode_FromId(&PyId_False); // borrowed ref
}

if (s != NULL){
return Py_NewRef(s);
}

return s;
}

Expand Down