Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
bpo-20364: Improve sqlite3 placeholder docs#25003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
erlend-aasland commented Mar 23, 2021 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
erlend-aasland commented Mar 23, 2021
@berkerpeksag, @terryjreedy: would you mind taking a look at this? |
Uh oh!
There was an error while loading. Please reload this page.
Fidget-Spinner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not an sqllite3 expert by any means, so I'll leave verifying the content's accuracy to someone else ;).
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
erlend-aasland commented Apr 5, 2021
Thanks for reviewing, @Fidget-Spinner, I appreciate your comments 😃 |
Fidget-Spinner left a comment • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for improving the docs :).
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
bedevere-bot commented Apr 14, 2021
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Uh oh!
There was an error while loading. Please reload this page.
erlend-aasland commented Apr 14, 2021
I have made the requested changes; please review again. |
bedevere-bot commented Apr 14, 2021
Thanks for making the requested changes! @berkerpeksag: please review the changes made to this pull request. |
berkerpeksag commented Apr 14, 2021
Ah, can you also fix the following error? You'll probably need to update |
erlend-aasland commented Apr 14, 2021 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
erlend-aasland commented Apr 14, 2021
Since this is a doc update, we'd want to backport it to 3.9 and 3.8, right? |
miss-islington commented Apr 14, 2021
Thanks @erlend-aasland for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
(cherry picked from commit 3386ca0) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
bedevere-bot commented Apr 14, 2021
GH-25402 is a backport of this pull request to the 3.9 branch. |
erlend-aasland commented Apr 14, 2021
Thanks for reviewing, @berkerpeksag ! |
Co-authored-by: Terry J. Reedy
https://bugs.python.org/issue20364