bpo-43795: Sort PC/python3dll.c#25312
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Each section is sorted to reduce diffs (review effort) when the file becomes generated. Sort is done with key=str.lower to preserve most of the original order (underscored items first).
MemberAuthor
I'm putting this up as a separate PR to reduce conflicts. Discussions on the main PEP 652 PR might take a while. |
zware reviewed Apr 9, 2021
Member
zware left a comment
zware left a comment There was a problem hiding this comment.
Looks like the file mode was changed; was that intentional? Otherwise looks good to me :)
pablogsal approved these changes Apr 11, 2021
I have no idea why that changed...
MemberAuthor
encukou commented Apr 14, 2021
I have no idea how I managed to change the mode. Thanks for the catch! |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each section is sorted to reduce diffs (review effort) when the file becomes generated (PEP 652)
Sort is done with key=str.lower to preserve most of the original order (underscored items first).
https://bugs.python.org/issue43795