Skip to content

Conversation

@pablogsal
Copy link
Member

@pablogsalpablogsal commented Apr 13, 2021

@pablogsalpablogsal changed the title Revert "[3.9] bpo-43725: Add ignore file for the abidump check"[3.9] Revert "[3.9] bpo-43725: Add ignore file for the abidump check"Apr 13, 2021
@vstinner
Copy link
Member

_Py_M__importlib_bootstrap_external should be ignored explictly, no? See: https://bugs.python.org/issue43725#msg390660

@pablogsal
Copy link
MemberAuthor

_Py_M__importlib_bootstrap_external should be ignored explictly, no? See: https://bugs.python.org/issue43725#msg390660

That is only for 3.8

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If we need to manually ignore symbols tomorrow, we can add again the ignorefile.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@pablogsal@vstinner@the-knights-who-say-ni@bedevere-bot