Skip to content

Conversation

@orsenthil
Copy link
Member

@orsenthilorsenthil commented Apr 29, 2021

PRs were failing with the check if generated files are up to date. For e.g this one.

The Stable ABI was updated here in this PR - #25315
The change in this diff was introduced here - 3cc481b

I had run make regen-limited-abi to recrete the stable abi manifest.

https://bugs.python.org/issue43774

@orsenthilorsenthil changed the title Update Stable ABI dat.bpo-43774 - Update Stable ABI dat.Apr 29, 2021
PyFrozenSet_New
PyFrozenSet_Type
PyGC_Collect
PyGC_Disable
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right to me and don't know how to read this.

This was the output of make regen-limited-abi

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@encukou - Please verify if this is correct.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that's not correct. Those should stay in the file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They probably need to get added to Misc/stable_abi.txt now. That seems to be the new source of truth. I'll add them there.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scoder - Thank you. I could update this PR with Misc/stable_abi.txt change too.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Petr took care of it - #25720

@orsenthilorsenthil requested a review from encukouApril 29, 2021 11:57
@orsenthilorsenthil changed the title bpo-43774 - Update Stable ABI dat.bpo-43795 - Update Stable ABI dat.Apr 29, 2021
@orsenthilorsenthil requested a review from scoderApril 29, 2021 12:49
@encukou
Copy link
Member

Oh, these are new symbols that got in as I merged PEP 652 commit. Sorry for the mismatch; I'll add them.
Details are in PEP 652, while I'm finishing up proper docs.

@orsenthil
Copy link
MemberAuthor

Updating this PR at the correct location.

@encukou
Copy link
Member

See GH-25720

@orsenthil
Copy link
MemberAuthor

Thank you. This is resolved by #25720

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@orsenthil@encukou@scoder@the-knights-who-say-ni@bedevere-bot