Skip to content

bpo-43933: Show frame.f_lineno as None, rather than -1, if there is no line number.#25717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
markshannon merged 3 commits into from
Apr 29, 2021
Merged

bpo-43933: Show frame.f_lineno as None, rather than -1, if there is no line number. #25717

markshannon merged 3 commits into from
Apr 29, 2021

Conversation

@markshannon
Copy link
Member

@markshannonmarkshannon commented Apr 29, 2021•
edited by bedevere-bot
Loading

As specified by PEP 626.
This should not be observable unless frame.f_trace_opcodes is set, or some other oddity.

https://bugs.python.org/issue43933

@markshannonmarkshannonforce-pushed the present-none-if-missing-lineno branch from 046b8ae to 9bd0186CompareApril 29, 2021 13:07
@encukou
Copy link
Member

encukou commented Apr 29, 2021

The "Check if generated files are up to date" test is failing because of unfortunate timing when merging other PRs (GH-25315, GH-25687).
It's OK to ignore it. Sorry for the inconvenience.

@markshannonmarkshannon merged commit 088a15c into python:masterApr 29, 2021
@markshannonmarkshannon deleted the present-none-if-missing-lineno branch May 4, 2021 09:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@markshannon@encukou@the-knights-who-say-ni@bedevere-bot