bpo-43916: Use Py_TPFLAGS_DISABLE_NEW flag in hashlib#25722
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add a new Py_TPFLAGS_DISABLE_NEW type flag to disallow creating instances of a type.
Signed-off-by: Christian Heimes <christian@python.org>
Member
vstinner commented Apr 30, 2021
I merged my PR #25721 and the flag was renamed. Can you please rebase your PR? |
vstinner approved these changes Apr 30, 2021
Member
vstinner left a comment
vstinner left a comment There was a problem hiding this comment.
LGTM. If you rebase your PR and rename Py_TPFLAGS_DISABLE_NEW flag to Py_TPFLAGS_DISALLOW_INSTANTIATION.
I only reviewed Lib/test/test_hashlib.py and Modules/_hashopenssl.c changes.
Member
vstinner commented Apr 30, 2021
I created PR #25745 which also updates the posix module. |
MemberAuthor
tiran commented Apr 30, 2021
Thanks Victor! |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue43916