Skip to content

bpo-43908: check_set_special_type_attr() and type_set_annotations() now check for immutable flag#25743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 8 commits into from
Apr 30, 2021
Merged

bpo-43908: check_set_special_type_attr() and type_set_annotations() now check for immutable flag #25743

vstinner merged 8 commits into from
Apr 30, 2021

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commented Apr 30, 2021•
edited
Loading

@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commented Apr 30, 2021

cc. @vstinner

@erlend-aaslanderlend-aasland changed the title bpo-43908: check_set_special_type_attr() now checks for Py_TPFLAGS_IMMUTABLETYPE…bpo-43908: check_set_special_type_attr() and type_set_annotations() now check for immutable flagApr 30, 2021
vstinner
vstinner reviewed Apr 30, 2021
View reviewed changes
Erlend Egeberg Aaslandand others added 2 commits April 30, 2021 12:43
vstinner
vstinner reviewed Apr 30, 2021
View reviewed changes
vstinner
vstinner reviewed Apr 30, 2021
View reviewed changes
@vstinner
Copy link
Member

vstinner commented Apr 30, 2021

test_descr does crash on the Windows CI.

@vstinner
Copy link
Member

vstinner commented Apr 30, 2021

I look the liberty of fixing '%R' before I noticed the test_descr crash :-(

@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commented Apr 30, 2021

I look the liberty of fixing '%R' before I noticed the test_descr crash :-(

Thanks, Victor! I'm offline for an hour now. Feel free to take care of the fixes and land the PR :) Or I'll look at it later this afternoon.

@vstinner
Copy link
Member

vstinner commented Apr 30, 2021

Thanks, Victor! I'm offline for an hour now. Feel free to take care of the fixes and land the PR :) Or I'll look at it later this afternoon.

No problem, I pushed a fix for test_descr in your PR.

@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commented Apr 30, 2021

Thanks!

@vstinnervstinner merged commit 6414138 into python:masterApr 30, 2021
@vstinner
Copy link
Member

vstinner commented Apr 30, 2021

Merged, thanks.

@erlend-aaslanderlend-aasland deleted the set-special branch April 30, 2021 13:29
@gvanrossumgvanrossum mentioned this pull request May 18, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner left review comments

@markshannonmarkshannonAwaiting requested review from markshannon

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland@vstinner@the-knights-who-say-ni@bedevere-bot