Skip to content

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commented Apr 30, 2021

The following types use Py_TPFLAGS_DISALLOW_INSTANTIATION flag:

  • _md5.md5
  • _sha1.sha1
  • _sha256.sha224
  • _sha256.sha256
  • _sha512.sha384
  • _sha512.sha512

https://bugs.python.org/issue43916

The following types use Py_TPFLAGS_DISALLOW_INSTANTIATION flag: * _md5.md5 * _sha1.sha1 * _sha256.sha224 * _sha256.sha256 * _sha512.sha384 * _sha512.sha512
@vstinner
Copy link
MemberAuthor

Windows (x64): test_asyncio failed, I re-run all jobs.

@tiran
Copy link
Member

Tests are failing. The failures look unrelated. Could you please file a bug report with asyncio and enum?

@tiran
Copy link
Member

 ====================================================================== ERROR: test_add_signal_handler_install_error3 (test.test_asyncio.test_unix_events.SelectorEventLoopSignalTests) ---------------------------------------------------------------------- test test_asyncio failed Traceback (most recent call last): File "/home/runner/work/cpython/cpython/Lib/asyncio/unix_events.py", line 116, in add_signal_handler signal.signal(sig, _sighandler_noop) File "/home/runner/work/cpython/cpython/Lib/unittest/mock.py", line 1105, in __call__ return self._mock_call(*args, **kwargs) File "/home/runner/work/cpython/cpython/Lib/unittest/mock.py", line 1109, in _mock_call return self._execute_mock_call(*args, **kwargs) File "/home/runner/work/cpython/cpython/Lib/unittest/mock.py", line 1164, in _execute_mock_call raise effect test.test_asyncio.test_unix_events.SelectorEventLoopSignalTests.test_add_signal_handler_install_error3.<locals>.Err During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/home/runner/work/cpython/cpython/Lib/unittest/mock.py", line 1370, in patched return func(*newargs, **newkeywargs) File "/home/runner/work/cpython/cpython/Lib/test/test_asyncio/test_unix_events.py", line 165, in test_add_signal_handler_install_error3 self.assertRaises( File "/home/runner/work/cpython/cpython/Lib/unittest/case.py", line 732, in assertRaises return context.handle('assertRaises', args, kwargs) File "/home/runner/work/cpython/cpython/Lib/unittest/case.py", line 201, in handle callable_obj(*args, **kwargs) File "/home/runner/work/cpython/cpython/Lib/asyncio/unix_events.py", line 129, in add_signal_handler raise RuntimeError(f'sig{sig} cannot be caught') File "/home/runner/work/cpython/cpython/Lib/enum.py", line 1019, in __format__ warnings.warn( DeprecationWarning: in 3.12 format() will use the enum member, not the enum member's value; use a format specifier, such as :d for an IntEnum member, to maintainthe current display 

@vstinner
Copy link
MemberAuthor

Tests are failing. The failures look unrelated. Could you please file a bug report with asyncio and enum?

I'm reporting test_asyncio failures for 2 years, nobody fix them. I sent two emails on python-dev.

I don't have the bandwidth to report the enum issue. I let someone else handling it ;-) It's unrelated to the PR.

@vstinnervstinner merged commit 665c774 into python:masterApr 30, 2021
@vstinnervstinner deleted the hash_disallow_instantiation branch April 30, 2021 16:40
@tiran
Copy link
Member

@vstinner Could you please give me time to verify PRs against modules that I'm responsible for? I was in the middle of verifying that test issues were unrelated.

@vstinner
Copy link
MemberAuthor

@vstinner Could you please give me time to verify PRs against modules that I'm responsible for? I was in the middle of verifying that test issues were unrelated.

Usually yes, but for this specific issue I couldn't, I needed to fix it before I leave for 1 week of holiday, and https://bugs.python.org/issue43916 was marked as a release blocker. I preferred to fix the issue than trying to explain the complex status "well, some types are fixed, but not all of them" :-D

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner@tiran@erlend-aasland@the-knights-who-say-ni@bedevere-bot