Skip to content

Conversation

@pablogsal
Copy link
Member

@pablogsalpablogsal commented May 1, 2021

@pablogsalpablogsal requested a review from a team as a code ownerMay 1, 2021 01:02
@pablogsalpablogsal requested a review from vstinnerMay 1, 2021 01:04
@pablogsalpablogsal merged commit 558df90 into python:masterMay 1, 2021
@pablogsalpablogsal deleted the bpo-43916 branch May 1, 2021 01:21
@vstinner
Copy link
Member

Why did you add the function to Doc/data/stable_abi.dat? It's excluded from the limited C API, it's only part of the internal C API.

@pablogsal
Copy link
MemberAuthor

Why did you add the function to Doc/data/stable_abi.dat? It's excluded from the limited C API, it's only part of the internal C API.

If you don't export it it won't be usable from the extension modules IIRC. The CI was failing if I just export it and I don't add it to the stable_abi file.

If you have a better way to structure it so is not exported, please go ahead and fix it.

@pablogsal
Copy link
MemberAuthor

Why did you add the function to Doc/data/stable_abi.dat? It's excluded from the limited C API, it's only part of the internal C API.

See #25854

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@pablogsal@vstinner@the-knights-who-say-ni@bedevere-bot