bpo-43905: Expand dataclasses.astuple() and asdict() docs#26154

akulakov · 2021-05-15T22:19:49Z

Expanded astuple() docs, warning about deepcopy being applied
and providing a workaround.

https://bugs.python.org/issue43905

Automerge-Triggered-By: GH:ericvsmith

Expanded ``astuple()`` docs.

Doc/library/dataclasses.rst

akulakov · 2021-05-24T05:02:03Z

@ericvsmith thanks for the review, updated per your comment.

github-actions · 2021-06-24T00:04:16Z

This PR is stale because it has been open for 30 days with no activity.

ericvsmith · 2021-11-28T19:20:38Z

Closing and re-opening in order to run tests again.

Doc/library/dataclasses.rst

bedevere-bot · 2021-11-29T00:54:45Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

ericvsmith

This looks good to me. Can you add the corresponding asdict change?

akulakov · 2021-11-29T04:28:43Z

@ericvsmith I've added the note and workaround to asdict and tweaked the wording a bit to make it clearer that the last paragraph refers to the respective function rather than the workaround example.

ericvsmith

Other than the news entry, this looks good to me.

ericvsmith · 2021-11-29T09:45:22Z

Misc/NEWS.d/next/Documentation/2021-05-24-05-00-12.bpo-43905.tBIndE.rst

@@ -0,0 +1,2 @@
+Expanded ``dataclasses.astuple()`` docs, warning about deepcopy being applied
+and providing a workaround.


This should also mention asdict().

akulakov · 2021-11-29T14:26:47Z

@ericvsmith Updated the news, please take a look.

miss-islington · 2021-11-29T18:10:35Z

Thanks @akulakov for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

…6154) Expanded ``astuple()`` docs, warning about deepcopy being applied and providing a workaround. Automerge-Triggered-By: GH:ericvsmith (cherry picked from commit c1f93f0) Co-authored-by: andrei kulakov <andrei.avk@gmail.com>

bedevere-bot · 2021-11-29T18:10:45Z

GH-29851 is a backport of this pull request to the 3.10 branch.

…6154) Expanded ``astuple()`` docs, warning about deepcopy being applied and providing a workaround. Automerge-Triggered-By: GH:ericvsmith (cherry picked from commit c1f93f0) Co-authored-by: andrei kulakov <andrei.avk@gmail.com>

bedevere-bot · 2021-11-29T18:10:49Z

GH-29852 is a backport of this pull request to the 3.9 branch.

Expanded ``astuple()`` docs, warning about deepcopy being applied and providing a workaround. Automerge-Triggered-By: GH:ericvsmith (cherry picked from commit c1f93f0) Co-authored-by: andrei kulakov <andrei.avk@gmail.com>

* main: (21 commits) bpo-45876: Have stdev() also use decimal specific square root. (pythonGH-29869) bpo-45876: Correctly rounded stdev() and pstdev() for the Decimal case (pythonGH-29828) bpo-45711: Change exc_info related APIs to derive type and traceback from the exception instance (pythonGH-29780) bpo-30533:Add function inspect.getmembers_static that does not call properties or dynamic properties. (python#20911) bpo-45476: Disallow using asdl_seq_GET() as l-value (pythonGH-29866) bpo-45476: Add _Py_RVALUE() macro (pythonGH-29860) bpo-33381: [doc] strftime's %f option may pad zeros on the left or the right (pythonGH-29801) Fix EncodingWarning in Tools/freeze/test/freeze.py (pythonGH-29742) no-issue: remove unused import from test_graphlib.py (pythonGH-29853) bpo-45931: Prevent Directory.Build.props/targets from leaking from directories above the repo when building on Windows (pythonGH-29854) bpo-45653: fix test_embed on windows (pythonGH-29814) bpo-45917: Add math.exp2() method - return 2 raised to the power of x (pythonGH-29829) bpo-43905: Expand dataclasses.astuple() and asdict() docs (pythonGH-26154) bpo-44391: Remove unused argument from a varargs call. (pythonGH-29843) bpo-45881: configure --with-freeze-module --with-build-python (pythonGH-29835) bpo-45847: PY_STDLIB_MOD_SIMPLE now checks py_stdlib_not_available (pythonGH-29844) bpo-45828: Use unraisable exceptions within sqlite3 callbacks (FH-29591) bpo-40280: Emscripten systems use .wasm suffix by default (pythonGH-29842) bpo-45723: Sort the grand AC_CHECK_HEADERS check (pythonGH-29846) bpo-45847: Make socket module conditional (pythonGH-29769) ...

…ct that they deep copy objects in the field values, according to the changes in the docs, see python#26154

Update dataclasses.rst
75a6626
Expanded ``astuple()`` docs.

akulakov requested a review from ericvsmith as a code owner May 15, 2021 22:19

bedevere-bot added the awaiting review label May 15, 2021

the-knights-who-say-ni added the CLA signed label May 15, 2021

bedevere-bot added the docs Documentation in the Doc dir label May 15, 2021

akulakov changed the title ~~bpo-43905: Expand dataclass.astuple() docs~~bpo-43905: Expand dataclasses.astuple() docsMay 15, 2021

ericvsmith reviewed May 15, 2021
View reviewed changes

Doc/library/dataclasses.rst Outdated Show resolvedHide resolved

akulakovand others added 2 commits May 24, 2021 00:52

Moved 'deepcopy' sentence to the first paragraph.
1b80a7a

📜🤖 Added by blurb_it.
390274c

github-actionsbot added the stale Stale PR or inactive for long period of time. label Jun 24, 2021

ericvsmith closed this Nov 28, 2021

ericvsmith reopened this Nov 28, 2021

ericvsmith requested changes Nov 29, 2021
View reviewed changes

Doc/library/dataclasses.rst Outdated Show resolvedHide resolved
Doc/library/dataclasses.rst Outdated Show resolvedHide resolved

bedevere-bot added awaiting changes and removed awaiting review labels Nov 29, 2021

akulakov added 2 commits November 28, 2021 20:33

fix trailing whitespace
be3feaf

fix one more trailing space
f0e5b87

ericvsmith requested changes Nov 29, 2021
View reviewed changes

akulakov added 2 commits November 28, 2021 23:06

added deepcopy note and workaround to asdict
f9f2734

remove tildes in links
fbcc54a

akulakov changed the title ~~bpo-43905: Expand dataclasses.astuple() docs~~bpo-43905: Expand dataclasses.astuple() and asdict() docsNov 29, 2021

ericvsmith requested changes Nov 29, 2021
View reviewed changes

ericvsmith removed the stale Stale PR or inactive for long period of time. label Nov 29, 2021

update news
4a8a2a7

ericvsmith added needs backport to 3.9 needs backport to 3.10 only security fixes labels Nov 29, 2021

ericvsmith approved these changes Nov 29, 2021
View reviewed changes

bedevere-bot added awaiting merge and removed awaiting changes labels Nov 29, 2021

miss-islington merged commit c1f93f0 into python:mainNov 29, 2021

bedevere-bot removed the awaiting merge label Nov 29, 2021

bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 29, 2021

bedevere-bot removed the needs backport to 3.9 label Nov 29, 2021

ischurov added a commit to ischurov/cpython that referenced this pull request Feb 10, 2023
Update dataclasses.astuple and dataclasses.asdict docstrings to refle…
c537df5
…ct that they deep copy objects in the field values, according to the changes in the docs, see python#26154

ischurov mentioned this pull request Feb 10, 2023
gh-88071: Update docstrings of dataclass' astuple and asdict #101806
Merged

mandolaerikmannequin mentioned this pull request Apr 10, 2022
dataclasses.astuple (and .asdict) do deepcopy on all fields #88071
Closed

		@@ -0,0 +1,2 @@
		Expanded ``dataclasses.astuple()`` docs, warning about deepcopy being applied
		and providing a workaround. No newline at end of file

Uh oh!

bpo-43905: Expand dataclasses.astuple() and asdict() docs#26154

bpo-43905: Expand dataclasses.astuple() and asdict() docs #26154

Uh oh!

Conversation

akulakov commented May 15, 2021• edited by miss-islington Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

akulakov commented May 24, 2021

Uh oh!

github-actionsbot commented Jun 24, 2021

Uh oh!

ericvsmith commented Nov 28, 2021

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Nov 29, 2021

Uh oh!

ericvsmith left a comment

Choose a reason for hiding this comment

Uh oh!

akulakov commented Nov 29, 2021

Uh oh!

ericvsmith left a comment

Choose a reason for hiding this comment

Uh oh!

ericvsmithNov 29, 2021

Choose a reason for hiding this comment

Uh oh!

akulakov commented Nov 29, 2021

Uh oh!

miss-islington commented Nov 29, 2021

Uh oh!

bedevere-bot commented Nov 29, 2021

Uh oh!

bedevere-bot commented Nov 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

akulakov commented May 15, 2021•
edited by miss-islington
Loading