Skip to content

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commented May 18, 2021

@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commented May 18, 2021

@pablogsal I'm adding skip news to this. Can be backported to 3.10 and 3.9 (3.8 doesn't even get doc updates anymore, right?).

@pablogsal
Copy link
Member

@pablogsal I'm adding skip news to this. Can be backported to 3.10 and 3.9 (3.8 doesn't even get doc updates anymore, right?).

Yep, docs changes can almost always be backported!

@erlend-aasland
Copy link
ContributorAuthor

Yep, docs changes can almost always be backported!

All right :) Thanks.

@erlend-aasland
Copy link
ContributorAuthor

But I note that Berker chose only to apply backport labels for 3.10 and 3.9 to GH-26027. Maybe do likewise here?

@pablogsal
Copy link
Member

But I note that Berker chose only to apply backport labels for 3.10 and 3.9 to GH-26027. Maybe do likewise here?

I don't see personally any problem of improving the docs of all versions even if they are in sec fixes only, bit maybe I am missing some context...

@berkerpeksagberkerpeksag merged commit 9014437 into python:mainMay 19, 2021
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2021
@bedevere-bot
Copy link

GH-26230 is a backport of this pull request to the 3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label May 19, 2021
@erlend-aaslanderlend-aasland deleted the bpo-30593 branch May 19, 2021 07:06
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2021
@bedevere-bot
Copy link

GH-26231 is a backport of this pull request to the 3.9 branch.

@erlend-aasland
Copy link
ContributorAuthor

Thanks for reviewing, Berker & Pablo!

@berkerpeksag
Copy link
Member

I don't see personally any problem of improving the docs of all versions even if they are in sec fixes only, bit maybe I am missing some context...

It's because historically online documentation of security-fix-only branches weren't updated daily.

berkerpeksag pushed a commit that referenced this pull request May 19, 2021
berkerpeksag pushed a commit that referenced this pull request May 19, 2021
@erlend-aaslanderlend-aasland mentioned this pull request Jul 27, 2022
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@erlend-aasland@pablogsal@miss-islington@bedevere-bot@berkerpeksag@the-knights-who-say-ni