Skip to content

bpo-42972: Fully support GC for hashlib heap types (GH-26374)#26374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tiran merged 4 commits into from
May 27, 2021
Merged

bpo-42972: Fully support GC for hashlib heap types (GH-26374) #26374

tiran merged 4 commits into from
May 27, 2021

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commented May 25, 2021•
edited by miss-islington
Loading

@tirantiran requested a review from gpsheadMay 26, 2021 14:55
@tirantiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 26, 2021
@bedevere-bot
Copy link

bedevere-bot commented May 26, 2021

🤖 New build scheduled with the buildbot fleet by @tiran for commit 49226dd 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 26, 2021
@tiran
Copy link
Member

tiran commented May 26, 2021

@pablogsal@erlend-aasland Lots of buildbots have failed with Master Shutdown. Is this an infrastructure issues? Can I just restart the buildbots by setting the label again?

@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commented May 26, 2021•
edited
Loading

@pablogsal@erlend-aasland Lots of buildbots have failed with Master Shutdown. Is this an infrastructure issues? Can I just restart the buildbots by setting the label again?

I've never seen this, but it does look like an infrastructure issue; the builds/tests did not fail, they were cancelled.

@pablogsal
Copy link
Member

pablogsal commented May 26, 2021

@pablogsal@erlend-aasland Lots of buildbots have failed with Master Shutdown. Is this an infrastructure issues? Can I just restart the buildbots by setting the label again?

That happens when the server restarts with an update, which happened because @vstinner updated the IRC configuration

@tirantiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 26, 2021
@bedevere-bot
Copy link

bedevere-bot commented May 26, 2021

🤖 New build scheduled with the buildbot fleet by @tiran for commit 49226dd 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 26, 2021
@tirantiran changed the title bpo-42972: Fully support GC for hashlib heap typesbpo-42972: Fully support GC for hashlib heap types (GH-26374)May 27, 2021
@tirantiran merged commit 6ef5ba3 into python:mainMay 27, 2021
@miss-islington
Copy link
Contributor

miss-islington commented May 27, 2021

Thanks @erlend-aasland for the PR, and @tiran for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented May 27, 2021

GH-26398 is a backport of this pull request to the 3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label May 27, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2021
@miss-islington
bpo-42972: Fully support GC for hashlib heap types (pythonGH-26374)
0f2ec18
(cherry picked from commit 6ef5ba3) Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@erlend-aaslanderlend-aasland deleted the bpo-42972/sha256 branch May 27, 2021 07:52
@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commented May 27, 2021

Thanks for reviewing, @gpshead and @tiran! 🙏🏻

miss-islington added a commit that referenced this pull request May 27, 2021
@miss-islington
[3.10]bpo-42972: Fully support GC for hashlib heap types (GH-26374) (G…
4431922
…H-26398) (cherry picked from commit 6ef5ba3) Co-authored-by: Erlend Egeberg Aasland <[email protected]> Automerge-Triggered-By: GH:tiran
@pablogsalpablogsal mentioned this pull request Jul 18, 2021
Closed
@vstinnervstinner mentioned this pull request Jun 9, 2022
Closed
This was referenced Dec 6, 2024
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpsheadgpsheadgpshead approved these changes

@tirantirantiran approved these changes

Assignees

@gpsheadgpshead

@tirantiran

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@erlend-aasland@bedevere-bot@tiran@pablogsal@miss-islington@gpshead@the-knights-who-say-ni