Skip to content

bpo-43916: Use test.support.check_disallow_instantiation in test_tcl#26412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 1 commit into from
May 27, 2021
Merged

bpo-43916: Use test.support.check_disallow_instantiation in test_tcl #26412

vstinner merged 1 commit into from
May 27, 2021

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commented May 27, 2021•
edited by bedevere-bot
Loading

@bedevere-botbedevere-bot added the tests Tests in the Lib/test dir label May 27, 2021
@erlend-aaslanderlend-aasland added needs backport to 3.10 only security fixes skip news and removed needs backport to 3.10 only security fixes labels May 27, 2021
@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commented May 27, 2021

From issue 43988:

Serhiy suggested to write an unit test for curses.ncurses_version: > https://bugs.python.org/issue43916#msg391936

Excerpt from msg391936:

I think it is better to add tests for different modules in corresponding module test files. They are pretty trivial, for example: def test_new_tcl_obj(self): self.assertRaises(TypeError, _tkinter.Tcl_Obj) @requires_curses_func('panel') def test_new_curses_panel(self): w = curses.newwin(10, 10) panel = curses.panel.new_panel(w) self.assertRaises(TypeError, type(panel))

test_new_curses_panel was added in GH-25748 and then converted to use the support helper in GH-26392.

I'm not sure if it makes sense to add a test for curses.ncurses_version.

@vstinnervstinner merged commit e90e042 into python:mainMay 27, 2021
@vstinner
Copy link
Member

vstinner commented May 27, 2021

Merged, thanks.

@erlend-aaslanderlend-aasland mentioned this pull request Jun 23, 2021
Merged
@erlend-aaslanderlend-aasland deleted the fixup-old-inst-tests branch June 24, 2021 07:40
@erlend-aaslanderlend-aasland added the needs backport to 3.10 only security fixes label Jun 24, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Jun 24, 2021

Thanks @erlend-aasland for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 24, 2021
@miss-islington
bpo-43916: Use test.support.check_disallow_instantiation() in test_tcl (
a04235e
pythonGH-26412) (cherry picked from commit e90e042) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot
Copy link

bedevere-bot commented Jun 24, 2021

GH-26888 is a backport of this pull request to the 3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label Jun 24, 2021
vstinner pushed a commit that referenced this pull request Jun 24, 2021
@miss-islington
bpo-43916: Use test.support.check_disallow_instantiation() in test_tcl (
7335870
GH-26412) (GH-26888) (cherry picked from commit e90e042) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@pablogsalpablogsal mentioned this pull request Jul 18, 2021
Closed
@pablogsalpablogsal mentioned this pull request May 18, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnerAwaiting requested review from vstinner

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erlend-aasland@vstinner@miss-islington@bedevere-bot@the-knights-who-say-ni