bpo-44087: Disallow instantiation of sqlite3.Statement#26567
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pablogsal approved these changes Jun 6, 2021
pablogsal approved these changes Jun 20, 2021
Contributor
miss-islington commented Jun 20, 2021
Thanks @erlend-aasland for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 20, 2021
(cherry picked from commit 7d0a47e) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
bedevere-bot commented Jun 20, 2021
GH-26813 is a backport of this pull request to the 3.10 branch. |
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Jun 20, 2021
pablogsal pushed a commit that referenced this pull request Jun 20, 2021
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Jun 23, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sqlite3.Statement type is not exposed, but it is possible to fetch it via the
sqlite3.Connection object. The statement type is an implementation detail; it
should not be possible to instantiate statement objects.
https://bugs.python.org/issue44087