Skip to content

Conversation

@isidentical
Copy link
Member

@isidenticalisidentical commented Jul 13, 2021

Purely for design purposes, do not review/merge.

https://bugs.python.org/issue43950

@isidenticalisidenticalforce-pushed the bpo-43950-source-tracking branch from ea92deb to 3d2919cCompareJuly 13, 2021 17:33
@isidentical
Copy link
MemberAuthor

isidentical commented Jul 17, 2021

One problem with this patch is that, we need to limit fetching from __source__ only for the main frame, otherwise if the offsets match out it will show something like this;

 $ ./pythonPython3.11.0a0 (heads/[bpo-43950](https://bugs.python.org/issue43950)-source-tracking-dirty:1173c11e09, Jul172021, 14:52:40) [GCC9.3.0] onlinuxType"help", "copyright", "credits"or"license"formoreinformation. >>>defframe_3(): ... return1/0 ... >>>defframe_2(): ... returnframe_3() ... >>>defframe_1(): ... returnframe_2() ... >>>ifTrue: ... 1+frame_1() ... Traceback (mostrecentcalllast): File"<stdin>", line2, in<module>1+frame_1() ^^^^^^^^^File"<stdin>", line2, inframe_11+frame_1() ^^^^^^^^^File"<stdin>", line2, inframe_21+frame_1() ^^^^^^^^^File"<stdin>", line2, inframe_31+frame_1() ^^^ZeroDivisionError: divisionbyzero

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsbot added the stale Stale PR or inactive for long period of time. label Aug 17, 2021
@github-actionsgithub-actionsbot removed the stale Stale PR or inactive for long period of time. label Aug 10, 2022
@CAM-Gerlach
Copy link
Member

Hey @isidentical , can this be closed now?

@isidentical
Copy link
MemberAuthor

Thanks for the reminder @CAM-Gerlach, this was mainly an experiment before it ever got to be a real PR so yep we can close it.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@isidentical@CAM-Gerlach@the-knights-who-say-ni@ezio-melotti@bedevere-bot