Skip to content

Conversation

@miss-islington
Copy link
Contributor

@miss-islingtonmiss-islington commented Jul 15, 2021

Patch by Erik Welch.

bpo-19072 (GH-8405) allows classmethod to wrap other descriptors, but this does
not work when the wrapped descriptor mimics classmethod. The current PR fixes
this.

In Python 3.8 and before, one could create a callable descriptor such that this
works as expected (see Lib/test/test_decorators.py for examples):

classA: @myclassmethoddeff1(cls): returncls@classmethod@myclassmethoddeff2(cls): returncls

In Python 3.8 and before, A.f2() return A. Currently in Python 3.9, it
returns type(A). This PR make A.f2() return A again.

As of GH-8405, classmethod calls obj.__get__(type) if obj has __get__.
This allows one to chain @classmethod and @property together. When
using classmethod-like descriptors, it's the second argument to __get__--the
owner or the type--that is important, but this argument is currently missing.
Since it is None, the "owner" argument is assumed to be the type of the first
argument, which, in this case, is wrong (we want A, not type(A)).

This PR updates classmethod to call obj.__get__(type, type) if obj has
__get__.

Co-authored-by: Erik Welch erik.n.welch@gmail.com
(cherry picked from commit b83861f)

Co-authored-by: Łukasz Langa lukasz@langa.pl

https://bugs.python.org/issue42073

…rs (pythonGH-27115) Patch by Erik Welch. bpo-19072 (pythonGH-8405) allows `classmethod` to wrap other descriptors, but this does not work when the wrapped descriptor mimics classmethod. The current PR fixes this. In Python 3.8 and before, one could create a callable descriptor such that this works as expected (see Lib/test/test_decorators.py for examples): ```python class A: @myclassmethod def f1(cls): return cls @classmethod @myclassmethod def f2(cls): return cls ``` In Python 3.8 and before, `A.f2()` return `A`. Currently in Python 3.9, it returns `type(A)`. This PR make `A.f2()` return `A` again. As of pythonGH-8405, classmethod calls `obj.__get__(type)` if `obj` has `__get__`. This allows one to chain `@classmethod` and `@property` together. When using classmethod-like descriptors, it's the second argument to `__get__`--the owner or the type--that is important, but this argument is currently missing. Since it is None, the "owner" argument is assumed to be the type of the first argument, which, in this case, is wrong (we want `A`, not `type(A)`). This PR updates classmethod to call `obj.__get__(type, type)` if `obj` has `__get__`. Co-authored-by: Erik Welch <erik.n.welch@gmail.com> (cherry picked from commit b83861f) Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@miss-islington
Copy link
ContributorAuthor

@ambv: Status check is done, and it's a success ✅ .

@ambvambv merged commit 2ce8af3 into python:3.10Jul 15, 2021
@miss-islingtonmiss-islington deleted the backport-b83861f-3.10 branch July 15, 2021 13:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@miss-islington@ambv@the-knights-who-say-ni@bedevere-bot