[3.10] bpo-44647: Fix test_httpservers failing on Unicode characters in os.environ on Windows (GH-27161)#27169
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…nviron on Windows (pythonGH-27161) pythonGH-23638 introduced a new test for Accept: headers in CGI HTTP servers. This test serializes all of os.environ on the server side. For non-UTF8 locales this can fail for some Unicode characters found in environment variables. This change fixes the HTTP_ACCEPT test. (cherry picked from commit 82b218f) Co-authored-by: Łukasz Langa <lukasz@langa.pl>
ContributorAuthor
miss-islington commented Jul 15, 2021
@ambv: Status check is done, and it's a success ✅ . |
2 similar comments
ContributorAuthor
miss-islington commented Jul 15, 2021
@ambv: Status check is done, and it's a success ✅ . |
ContributorAuthor
miss-islington commented Jul 15, 2021
@ambv: Status check is done, and it's a success ✅ . |
bedevere-bot commented Jul 15, 2021
@ambv: Please replace |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GH-23638 introduced a new test for Accept: headers in CGI HTTP servers. This test serializes all of os.environ on the server side. For non-UTF8 locales this can fail for some Unicode characters found in environment variables. This change fixes the HTTP_ACCEPT test.
(cherry picked from commit 82b218f)
Co-authored-by: Łukasz Langa lukasz@langa.pl
https://bugs.python.org/issue44647