Skip to content

bpo-43950: distinguish errors happening on character offset decoding#27217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pablogsal merged 1 commit into from
Jul 20, 2021
Merged

bpo-43950: distinguish errors happening on character offset decoding #27217

pablogsal merged 1 commit into from
Jul 20, 2021

Conversation

@isidentical
Copy link
Member

@isidenticalisidentical commented Jul 17, 2021•
edited by bedevere-bot
Loading

_PyPegen_byte_offset_to_character_offset now returns -1 on error since we need to distinguish 0-width lines from errors. Also the error checks are added to the call sites.

https://bugs.python.org/issue43950

@pablogsalpablogsal merged commit fbc349f into python:mainJul 20, 2021
@isidentical
Copy link
MemberAuthor

isidentical commented Jul 20, 2021

Thanks @pablogsal!

@pablogsalpablogsal mentioned this pull request Apr 13, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsalpablogsalpablogsal approved these changes

@ammaraskarammaraskarAwaiting requested review from ammaraskar

@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@isidentical@pablogsal@the-knights-who-say-ni@bedevere-bot