Skip to content

bpo-33479: add architecture and threading model sections to Tkinter module docs#27717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ambv merged 6 commits into from
Aug 11, 2021
Merged

bpo-33479: add architecture and threading model sections to Tkinter module docs #27717

ambv merged 6 commits into from
Aug 11, 2021

Conversation

@roseman
Copy link
Contributor

@rosemanroseman commented Aug 10, 2021•
edited by bedevere-bot
Loading

new sections added (originally from a previous PR...)

  • expanded introduction
  • architecture explaining tcl/tk/ttk/tix
  • threading model description and special cases

https://bugs.python.org/issue33479

@bedevere-botbedevere-bot added awaiting review docs Documentation in the Doc dir labels Aug 10, 2021
@roseman
Copy link
ContributorAuthor

roseman commented Aug 10, 2021

Main new sections from previous PR, will add changes and other bits in other PR's. Thanks for your help @ambv !

ambv
ambv reviewed Aug 11, 2021
View reviewed changes
@ambvambv merged commit 08caf2d into python:mainAug 11, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Aug 11, 2021

Thanks @roseman for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Aug 11, 2021

GH-27730 is a backport of this pull request to the 3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label Aug 11, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 11, 2021
@roseman@miss-islington
bpo-33479: Add architecture and threading model sections to Tkinter m…
b11bac8
…odule docs (pythonGH-27717) Co-authored-by: Łukasz Langa <lukasz@langa.pl> (cherry picked from commit 08caf2d) Co-authored-by: Mark Roseman <mark@markroseman.com>
@ambv
Copy link
Contributor

ambv commented Aug 11, 2021

Thanks, Mark! ✨ 🍰 ✨

miss-islington added a commit that referenced this pull request Aug 11, 2021
@miss-islington@roseman
bpo-33479: Add architecture and threading model sections to Tkinter m…
2666d70
…odule docs (GH-27717) Co-authored-by: Łukasz Langa <lukasz@langa.pl> (cherry picked from commit 08caf2d) Co-authored-by: Mark Roseman <mark@markroseman.com>
@ambvambv mentioned this pull request Aug 11, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambvambvambv left review comments

Assignees

No one assigned

Labels

awaiting reviewdocsDocumentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@roseman@miss-islington@bedevere-bot@ambv@the-knights-who-say-ni