Skip to content

bpo-44524: Don't modify MRO when inheriting from typing.Annotated#27841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 5 commits into from
Aug 25, 2021
Merged

bpo-44524: Don't modify MRO when inheriting from typing.Annotated #27841

serhiy-storchaka merged 5 commits into from
Aug 25, 2021

Conversation

@Fidget-Spinner
Copy link
Member

@Fidget-SpinnerFidget-Spinner commented Aug 19, 2021•
edited by bedevere-bot
Loading

@Fidget-SpinnerFidget-Spinner added needs backport to 3.10 only security fixes type-bug An unexpected behavior, bug, or error labels Aug 19, 2021
serhiy-storchaka
serhiy-storchaka reviewed Aug 20, 2021
View reviewed changes
@serhiy-storchakaserhiy-storchaka mentioned this pull request Aug 21, 2021
Merged
@Fidget-Spinner
Copy link
MemberAuthor

Fidget-Spinner commented Aug 21, 2021

Wait don't merge yet, I need to update some things.

@Fidget-SpinnerFidget-Spinner marked this pull request as draft August 21, 2021 06:51
@Fidget-Spinner
Copy link
MemberAuthor

Fidget-Spinner commented Aug 21, 2021•
edited
Loading

Interestingly, Annotated[Any, 'foo'].__name__ now returns Any, because it sets origin to Any.

This behavior is quite opinionated, but is consistent with how get_type_hints treats Annotated (it strips the Annotated information and just gives the contained type). Nonetheless, I have made it return 'Annotated'.

@Fidget-SpinnerFidget-Spinner marked this pull request as ready for review August 21, 2021 08:08
@Fidget-SpinnerFidget-Spinner changed the title bpo-44524: Temporarily exclude _name from typing.Annotatedbpo-44524: Don't modify MRO when inheriting from typing.AnnotatedAug 21, 2021
@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Aug 25, 2021

Merge?

@Fidget-Spinner
Copy link
MemberAuthor

Fidget-Spinner commented Aug 25, 2021

Merge?

Please do. I don't have permissions to merge this myself.

@serhiy-storchakaserhiy-storchaka merged commit 23384a1 into python:mainAug 25, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Aug 25, 2021

Thanks @Fidget-Spinner for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label Aug 25, 2021
@bedevere-bot
Copy link

bedevere-bot commented Aug 25, 2021

GH-27950 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 25, 2021
@Fidget-Spinner@miss-islington
bpo-44524: Don't modify MRO when inheriting from typing.Annotated (py…
7e1786c
…thonGH-27841) (cherry picked from commit 23384a1) Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Aug 25, 2021
@miss-islington@Fidget-Spinner
bpo-44524: Don't modify MRO when inheriting from typing.Annotated (GH…
06e9a35
…-27841) (cherry picked from commit 23384a1) Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
@Fidget-SpinnerFidget-Spinner deleted the name_annotated branch August 26, 2021 12:43
@tk0miyatk0miya mentioned this pull request Aug 29, 2021
Closed
@farcatfarcatmannequin mentioned this pull request Apr 14, 2022
Closed
@sobolevnsobolevn mentioned this pull request Sep 12, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@gvanrossumgvanrossumAwaiting requested review from gvanrossum

Assignees

No one assigned

Labels

skip newstype-bugAn unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Fidget-Spinner@serhiy-storchaka@miss-islington@bedevere-bot@the-knights-who-say-ni