Skip to content

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commented Aug 22, 2021

  • remove 'next_row' member from Cursor object
  • remove _pysqlite_fetch_one_row() call from query execute loop
  • as a result of the two above, pysqlite_cursor_iternext() is vastly simplified

https://bugs.python.org/issue44976

- remove 'next_row' member in Cursor object - remove fetch-one-row call from query execute loop - rewrite cursor iternext method to comply with the new behaviour
@erlend-aasland
Copy link
ContributorAuthor

Internal change; no user-visible or backwards incompatible changes; skipping news.

@erlend-aaslanderlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 22, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit ce0d55f 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 22, 2021
@erlend-aasland
Copy link
ContributorAuthor

The AMD64 Arch Linux Asan Debug PR buildbot failure seems to be unrelated. I see that it's been failing a lot recently.

@pablogsalpablogsal merged commit 3df0fc8 into python:mainAug 25, 2021
@erlend-aaslanderlend-aasland deleted the sqlite-fetch-when-needed branch August 25, 2021 10:31
@erlend-aasland
Copy link
ContributorAuthor

Thanks, Pablo!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland@bedevere-bot@pablogsal@the-knights-who-say-ni