bpo-37596: Make `set` and `frozenset` marshalling deterministic#27926

brandtbucher · 2021-08-24T04:48:14Z

This PR is intended as an alternative to #27769.

https://bugs.python.org/issue37596

bedevere-bot · 2021-08-24T08:06:56Z

🤖 New build scheduled with the buildbot fleet by @ambv for commit 597be1c 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

brandtbucher · 2021-08-24T13:28:47Z

Buildbot failure looks unrelated (it seems to have been having that issue for several days).

Lib/test/test_marshal.py

Misc/NEWS.d/next/Library/2021-08-23-21-39-59.bpo-37596.ojRcwB.rst

Python/marshal.c

bedevere-bot · 2021-08-25T03:30:57Z

🤖 New build scheduled with the buildbot fleet by @rhettinger for commit 23723cb 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

Implemented in: python/cpython#27926 We keep using it thou, because this is Python version agnostic. Once we drop support for anything older than 3.11, we can remove it. That'll be around ~2030. Assuming the world still exists by then.

…ation patches from: python/cpython#27926 python/cpython#8226 Both of these are included in python 3.11 upstream.

Implemented in: python/cpython#27926 We keep using it thou, because this is Python version agnostic. Once we drop support for anything older than 3.11, we can remove it. That'll be around ~2030. Assuming the world still exists by then.

…ation patches from: python/cpython#27926 python/cpython#8226 Both of these are included in python 3.11 upstream.

brandtbucherand others added 3 commits August 23, 2021 18:34

Serialize frozenset elements deterministically
af19777

Add regression test
ae38619

blurb add
4be57ef

brandtbucher requested a review from tiran as a code owner August 24, 2021 04:48

the-knights-who-say-ni added the CLA signed label Aug 24, 2021

bedevere-bot added the awaiting core review label Aug 24, 2021

brandtbucher added 3 commits August 23, 2021 21:49

Fix comment
1aff762

Cleanup
b71204e

More cleanup
597be1c

ambv mentioned this pull request Aug 24, 2021
bpo-37596: compile to reproducible frozen sets #27769
Closed

ambv added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 24, 2021

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 24, 2021