bpo-44991: Normalise sqlite3 callback naming#28088
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
encukou commented Sep 1, 2021
What about This PR turns out to be very small; maybe combine it with the next step if there is one coming? |
ContributorAuthor
Thanks for the heads-up. I'll add it right away.
The next step of normalising is approximately 100 lines added and removed; I think it would clutter things too much. I'm fine with that, but it may be more timeconsuming to review. |
erlend-aasland changed the title sqlite3 callback suffixessqlite3 callbacks, part 1erlend-aasland changed the title sqlite3 callbacks, part 1sqlite3 callback naming, part 1ContributorAuthor
I'll include the other changes; if you think it's too much, we can just revert that commit. I see the diff wasn't as bad as I expected. Only 60-ish lines. |
- all callbacks are now named xxx_callback - normalise callable naming in set_*() functions - normalise context argument naming in callbacks
erlend-aaslandforce-pushed the sqlite-normlise-callback-naming branch from df3becb to 0a9d214Compareerlend-aasland changed the title sqlite3 callback naming, part 1sqlite3 callback naming
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue44991