Skip to content

Conversation

@Ronbalt
Copy link

Just a typo since the code example above indicates that an IOError is thrown, and not an OSError.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@Ronbalt

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-botbedevere-bot added awaiting review docs Documentation in the Doc dir labels Sep 3, 2021
@serhiy-storchaka
Copy link
Member

Should not OSError be used?

@Ronbalt
Copy link
Author

Should not OSError be used?

Do you mean in the example itself?
I do not really care what exception to be used as long as it is consistent with the output.

File "<stdin>", line 2, in <module>
File "<stdin>", line 2, in func
OSError
IOError
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would have thought so, but actually IOError is an alias for OSError and this output is actually correct. I would suggest to replace the exception by some other type which is more suitable for a tutorial example.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>>> str(IOError) "<class 'OSError'>" 

@Mariatta
Copy link
Member

Can you create this against the main branch first? Or does it not exist in the main branch?

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity. If the CLA is not signed within 14 days, it will be closed. See also https://devguide.python.org/pullrequest/#licensing

@github-actionsgithub-actionsbot added the stale Stale PR or inactive for long period of time. label Feb 18, 2022
@github-actions
Copy link

Closing this stale PR because the CLA is still not signed.

@hugovk
Copy link
Member

Just a note that any IOError / OSError confusion was cleared up in #23160 by replacing it with ConnectionError.

Also that was merged in December 2020, 9 months before this was opened. It was probably missed since this opened against the 3.9 branch instead of main.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting core reviewdocsDocumentation in the Doc dirstaleStale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@Ronbalt@the-knights-who-say-ni@serhiy-storchaka@Mariatta@hugovk@iritkatriel@kasefuchs@bedevere-bot