bpo-45116: Add the Py_ALWAYS_INLINE macro#28390
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
vstinner commented Sep 16, 2021
I decided to split my old PR #28141 in two parts:
|
Add the Py_ALWAYS_INLINE macro to ask the compiler to always inline a static inline function. The compiler can ignore it and decides to not inline the function.
MemberAuthor
vstinner commented Sep 16, 2021
PR rebased to retrieve the Windows build fix. |
erlend-aasland approved these changes Sep 17, 2021
Contributor
erlend-aasland left a comment
erlend-aasland left a comment There was a problem hiding this comment.
How about a What's New entry?
MemberAuthor
vstinner commented Sep 17, 2021
I don't want to advertise too much this macro :-D As I wrote in its documentation, misusing it can make the code slower. Also, I'm not even sure if it should be used in Python :-) Benchmarks will give us some hints ;-) |
niyas-sait pushed a commit to niyas-sait/cpython that referenced this pull request Sep 21, 2021
Add the Py_ALWAYS_INLINE macro to ask the compiler to always inline a static inline function. The compiler can ignore it and decides to not inline the function.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the Py_ALWAYS_INLINE macro to ask the compiler to always inline a
static inline function. The compiler can ignore it and decides to not
inline the function.
https://bugs.python.org/issue45116