gh-84683: Check in <prefix>/share/zoneinfo for zoneinfo files on Windows#28495
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This PR is stale because it has been open for 30 days with no activity. |
zooba reviewed Feb 26, 2024
Uh oh!
There was an error while loading. Please reload this page.
Member
zooba commented Feb 26, 2024
LGTM, though I'd like to have a comment at least acknowledging that this path is one guess, and not in any way a standard or expectation. There's also a merge conflict of some kind. |
StanFromIreland changed the title <prefix>/share/zoneinfo for zoneinfo files on Windows
Member
StanFromIreland commented Jul 7, 2025
@zooba, do you still want to implement this? I can fix the conflict. |
Member
zooba commented Jul 7, 2025
Yeah, it seems a reasonable thing to allow. |
# Conflicts: # Lib/sysconfig.py
ContributorAuthor
isuruf commented Aug 6, 2025
@StanFromIreland thanks for rebasing. Ready for a review again. |
zooba merged commit 3000594 into python:main 42 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…dows
This is a relocatable path and conda uses this path for zoneinfo files on windows.
https://bugs.python.org/issue40503