bpo-39026: Rename Include/cpython/ header files#28612
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Header files of the Include/cpython/ subdirectory now get a "cpython_" prefix in their filename to avoid confusion between Include/<header>.h and Include/cpython/<header.h> (previously both files had the same name), especially when a cpython header file includes another cpython header file. Headers of the Include/cpython/ subdirectory cannot be included directly, so this change has no impact on the C API. cpython_pystate.h now includes "cpython_initconfig.h" rather than "cpython/initconfig.h" to fix building Python on macOS Framework.
MemberAuthor
vstinner commented Sep 29, 2021
That's a known test_asyncio bug: test_sendfile_close_peer_in_the_middle_of_receiving. It's unrelated to my PR. |
MemberAuthor
vstinner commented Oct 12, 2021
I prefer to abandon my PR for now. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Header files of the Include/cpython/ subdirectory now get a
.h and Include/cpython/<header.h> (previously both"cpython_" prefix in their filename to avoid confusion between
Include/
files had the same name), especially when a cpython header file
includes another cpython header file. Headers of the Include/cpython/
subdirectory cannot be included directly, so this change has no
impact on the C API.
cpython_pystate.h now includes "cpython_initconfig.h" rather than
"cpython/initconfig.h" to fix building Python on macOS Framework.
https://bugs.python.org/issue39026