Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
bpo-45229: Make datetime tests discoverable#28615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-45229: Make datetime tests discoverable #28615
Uh oh!
There was an error while loading. Please reload this page.
Conversation
serhiy-storchaka commented Sep 29, 2021 • edited by bedevere-bot
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by bedevere-bot
Uh oh!
There was an error while loading. Please reload this page.
| return tests | ||
| def test_main(): | ||
| run_unittest(*all_test_classes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this isn't used anymore, the import of run_unittest isn't necessary either.
serhiy-storchakaSep 29, 2021 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I missed this.
ambv left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test_datetime on main: Ran 960 tests in 9.497s; OK (skipped=28)
test_datetime on this PR: Ran 960 tests in 9.468s; OK (skipped=28)
Same tests running:
--- /tmp/main_datetime.log 2021-09-29 21:26:34.000000000 +0200 +++ /tmp/28615_datetime.log 2021-09-29 21:28:25.000000000 +0200 @@ -1 +1 @@ -Wed Sep 29 21:26:23 CEST 2021 +Wed Sep 29 21:28:14 CEST 2021 @@ -3 +3 @@ -== CPython 3.11.0a0 (heads/main:45ca1c0413, Sep 29 2021, 21:24:05) [Clang 12.0.0 (clang-1200.0.32.29)] +== CPython 3.11.0a0 (heads/test-datetime-discover:1131d9fb69, Sep 29 2021, 21:27:42) [Clang 12.0.0 (clang-1200.0.32.29)] @@ -5 +5 @@ -== cwd: /Users/ambv/Dropbox/Python/cpython/build/test_python_40589æ +== cwd: /Users/ambv/Dropbox/Python/cpython/build/test_python_49597æ @@ -8,2 +8,2 @@ -0:00:00 load avg: 2.35 Run tests sequentially -0:00:00 load avg: 2.35 [1/1] test_datetime +0:00:00 load avg: 3.01 Run tests sequentially +0:00:00 load avg: 3.01 [1/1] test_datetime @@ -982 +982 @@ -Ran 960 tests in 9.497s +Ran 960 tests in 9.468s miss-islington commented Sep 29, 2021
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
(cherry picked from commit d441437) Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington commented Sep 29, 2021
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
bedevere-bot commented Sep 29, 2021
GH-28639 is a backport of this pull request to the 3.10 branch. |
(cherry picked from commit d441437) Co-authored-by: Serhiy Storchaka <[email protected]>
bedevere-bot commented Sep 30, 2021
GH-28645 is a backport of this pull request to the 3.9 branch. |
pablogsal commented Sep 30, 2021
Unfortunately, this PR seems to have broken a bunch of buildbots. For instance: https://buildbot.python.org/all/#/builders/75/builds/172/steps/5/logs/stdio |
bedevere-bot commented Sep 30, 2021
|
bedevere-bot commented Sep 30, 2021
|
bedevere-bot commented Sep 30, 2021
|
bedevere-bot commented Sep 30, 2021
|
bedevere-bot commented Sep 30, 2021
|
…8615). (pythonGH-28645)" This reverts commit 993a130.
miss-islington commented Sep 30, 2021
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
miss-islington commented Oct 1, 2021
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
bedevere-bot commented Oct 1, 2021
GH-28668 is a backport of this pull request to the 3.10 branch. |
(cherry picked from commit d441437) Co-authored-by: Serhiy Storchaka <[email protected]>
(cherry picked from commit d441437) Co-authored-by: Serhiy Storchaka <[email protected]>
bedevere-bot commented Oct 1, 2021
|
https://bugs.python.org/issue45229