Skip to content

Conversation

@tiran
Copy link
Member

@tirantiran commented Nov 6, 2021

AC_PROG_EGREP should be checked explicitly.

AC_CONFIG_HEADER -> AC_CONFIG_HEADERS

AC_USE_SYSTEM_EXTENSIONS must be defined before first use of AC_LINK
or AC_COMPILE macros.

STDC_HEADERS and AC_HEADER_TIME are obsolete.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue45723

@tirantiran marked this pull request as ready for review November 7, 2021 09:34
@tirantiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 7, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @tiran for commit 2b2a10ebcb4216c271248e2191c64f29a7a68912 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 7, 2021
@tiran
Copy link
MemberAuthor

tiran commented Nov 8, 2021

All changes are based on the output of 2.71's autoupdate tool.

Copy link
Contributor

@erlend-aaslanderlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a quick look and left some comments.

@tiran
Copy link
MemberAuthor

tiran commented Nov 8, 2021

autoconf 2.71 has deprecated the macro:

configure.ac:660: warning: The macro `AC_PROG_CC_C99' is obsolete. configure.ac:660: You should run autoupdate. 

@erlend-aasland
Copy link
Contributor

autoconf 2.71 has deprecated the macro:

configure.ac:660: warning: The macro `AC_PROG_CC_C99' is obsolete. configure.ac:660: You should run autoupdate. 

Oh, well 😆

@tiran
Copy link
MemberAuthor

tiran commented Nov 8, 2021

In autoconf 2.71, AC_PROG_CC_C99 is an alias for AC_PROG_CC

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Nov 8, 2021

In autoconf 2.71, AC_PROG_CC_C99 is an alias for AC_PROG_CC

It seems that we can use AC_PROG_CC and check ac_cv_prog_cc_c99:

Otherwise, if ac_cv_prog_cc_c99 is set to any value other than ‘no’ (including the empty string), then CC can compile code as standard C 1999, and this mode has been enabled 

@erlend-aasland
Copy link
Contributor

BTW, we need to make sure we set CFLAGS before calling AC_PROG_CC, so we don't accidentally default to -g -O2.

@tiran
Copy link
MemberAuthor

tiran commented Nov 8, 2021

In autoconf 2.71, AC_PROG_CC_C99 is an alias for AC_PROG_CC

It seems that we can use AC_PROG_CC and check ac_cv_prog_cc_c99:

Otherwise, if ac_cv_prog_cc_c99 is set to any value other than ‘no’ (including the empty string), then CC can compile code as standard C 1999, and this mode has been enabled 

autoconf 2.71 no longer defines the variable ac_cv_prog_cc_c99. autoconf 2.69 only defines it for AC_PROG_CC_STDC.

Copy link
Contributor

@erlend-aaslanderlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think one NEWS entry is enough ;)

``AC_PROG_EGREP`` should be checked explicitly. ``AC_CONFIG_HEADER`` -> ``AC_CONFIG_HEADERS`` ``AC_USE_SYSTEM_EXTENSIONS`` must be defined before first use of ``AC_LINK`` or ``AC_COMPILE`` macros. ``STDC_HEADERS`` and ``AC_HEADER_TIME`` are obsolete. Signed-off-by: Christian Heimes <christian@python.org>
@tiran
Copy link
MemberAuthor

tiran commented Nov 8, 2021

LGTM, but I think one NEWS entry is enough ;)

Oops :)

I have removed the second entry and rebased the PR.

@tirantiran changed the title bpo-45723: Prepare support for autoconf 2.71bpo-45723: Prepare support for autoconf 2.71 (GH-29441)Nov 8, 2021
@tirantiran merged commit cbab997 into python:mainNov 8, 2021
@tirantiran deleted the bpo-45723-prep271 branch November 8, 2021 18:31
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tiran@bedevere-bot@erlend-aasland@the-knights-who-say-ni