Skip to content

Conversation

@tiran
Copy link
Member

@tirantiran commented Nov 6, 2021

@tirantiran changed the title Detect missing pkg-configbpo-45723: Detect missing pkg-configNov 6, 2021
Copy link
Member

@ned-deilyned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is AC_PATH_TOOL being picked up from? The current PR doesn't work for me.

@ned-deily
Copy link
Member

[...] config.status: creating pyconfig.h creating Modules/Setup.local creating Makefile pkg-config is missing. Some dependencies may not be detected correctly. If you want a release build with all stable optimizations active (PGO, etc), please run ./configure --enable-optimizations $ pkg-config Must specify package names on the command line $ which pkg-config /usr/bin/pkg-config 

This is on a reasonably vanilla Debian system. Also the same on macOS with pkg-config installed from MacPorts.

@tiran
Copy link
MemberAuthor

tiran commented Nov 6, 2021

Strange ... could you please paste the output of grep PKG_CONFIG config.log ?

My system (Fedora 34):

$ grep PKG_CONFIG config.log ac_cv_env_PKG_CONFIG_LIBDIR_set= ac_cv_env_PKG_CONFIG_LIBDIR_value= ac_cv_env_PKG_CONFIG_PATH_set= ac_cv_env_PKG_CONFIG_PATH_value= ac_cv_env_PKG_CONFIG_set= ac_cv_env_PKG_CONFIG_value= ac_cv_path_ac_pt_PKG_CONFIG=/usr/bin/pkg-config ac_cv_prog_ac_ct_PKG_CONFIG=/usr/bin/pkg-config PKG_CONFIG='/usr/bin/pkg-config' PKG_CONFIG_LIBDIR='' PKG_CONFIG_PATH='' 

@tiran
Copy link
MemberAuthor

tiran commented Nov 6, 2021

Where is AC_PATH_TOOL being picked up from? The current PR doesn't work for me.

AC_PATH_TOOL is provided by autoconf/programs.m4.

@tiran
Copy link
MemberAuthor

tiran commented Nov 6, 2021

D'oh, I put test -n to test the output message and forgot to replace it with test -z.

@tirantiran marked this pull request as ready for review November 6, 2021 19:01
@tirantiran changed the title bpo-45723: Detect missing pkg-configbpo-45723: Detect missing pkg-config (GH-29442)Nov 7, 2021
@tirantiran merged commit be3cd5c into python:mainNov 7, 2021
@tirantiran deleted the bpo-45723-pkgconf branch November 7, 2021 10:18
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
remykarem pushed a commit to remykarem/cpython that referenced this pull request Jan 30, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tiran@ned-deily@pablogsal@the-knights-who-say-ni@bedevere-bot