bpo-45711: Re-bump the magic number and update doc#29528
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
iritkatriel approved these changes Nov 12, 2021
Member
iritkatriel left a comment
iritkatriel left a comment There was a problem hiding this comment.
Thanks I noticed the opcode doc omission yesterday too. It didn’t occur to me to put it in what’s new though. It seems like something users shouldn’t really care about. I guess the release manager can decide.
iritkatriel changed the title remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
remykarem pushed a commit to remykarem/cpython that referenced this pull request Jan 30, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@iritkatriel, it looks like I chose the same new magic number as you for my recent PR. Sorry about that!
In addition to re-bumping the value, I also went ahead and updated a few docs.
https://bugs.python.org/issue45711