[3.9] bpo-45772: socket.socket should be a class instead of a function (GH-23960)#29543
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…honGH-23960) * bpo-45772: socket.socket should be a class instead of a function Currently `socket.socket` is documented as a function, but it is really a class (and thus has function-like usage to construct an object). This correction would ensure that Python projects that are interlinking Python's documentation can properly locate `socket.socket` as a type. (cherry picked from commit 4c792f3) Co-authored-by: Hong Xu <hong@topbug.net>
ContributorAuthor
miss-islington commented Nov 13, 2021
1 similar comment
ContributorAuthor
miss-islington commented Nov 13, 2021
asvetlov approved these changes Nov 13, 2021
ContributorAuthor
miss-islington commented Nov 13, 2021
@miss-islington: Status check is done, and it's a success ✅ . |
ContributorAuthor
miss-islington commented Nov 13, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
socket.socketis documented as a function, but it is reallya class (and thus has function-like usage to construct an object). This
correction would ensure that Python projects that are interlinking
Python's documentation can properly locate
socket.socketas a type.(cherry picked from commit 4c792f3)
Co-authored-by: Hong Xu hong@topbug.net
https://bugs.python.org/issue45772
Automerge-Triggered-By: GH:asvetlov