Skip to content

Conversation

@tiran
Copy link
Member

@tirantiran commented Nov 24, 2021

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @tiran for commit e39443e8c0770623ca81d8b17ff3317d2010361c 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 24, 2021
@tiran
Copy link
MemberAuthor

@ned-deily@ronaldoussoren I need your help with the macOS part of the patch. setup.py does some macOS specific things that I don't understand.

@ronaldoussoren
Copy link
Contributor

Which parts do you need help with?

It should be possible to move the macOS logic to configure.ac, although I'm a bit hazy at the moment about why some of the logic is there and some of the logic might be broken (in particular the code that sets USING_APPLE_OS_LIBFFI seems dodgy when self.use_system_libffi is false).

I can look into this at the end of the week.

BTW. Feel free to ping me directly, I don't regularly look at GitHub messages and only noticed your question promptly because Mail.app claimed it was junk mail.

@tirantiran marked this pull request as ready for review November 28, 2021 12:07
@tirantiran changed the title bpo-45847: Port _ctypes partly to PY_STDLIB_MODbpo-45847: Port _ctypes partly to PY_STDLIB_MOD (GH-29747)Dec 4, 2021
@tirantiran merged commit 4045392 into python:mainDec 4, 2021
@tirantiran deleted the bpo-45847-ctypes branch December 4, 2021 10:21
@pablogsal
Copy link
Member

@tiran After this PR, the gentoo builder is failing:

https://buildbot.python.org/all/#/builders/58/builds/1217

test_free_called (test.test_code.CoExtra) ... Fatal Python error: Illegal instruction Current thread 0xb7bd4700 (most recent call first): File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_code.py", line 575 in test_free_called File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/unittest/case.py", line 547 in _callTestMethod File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/unittest/case.py", line 591 in run File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/unittest/case.py", line 646 in __call__ File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/unittest/suite.py", line 122 in run File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/unittest/suite.py", line 84 in __call__ File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/unittest/suite.py", line 122 in run File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/unittest/suite.py", line 84 in __call__ File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/unittest/suite.py", line 122 in run File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/unittest/suite.py", line 84 in __call__ File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/unittest/runner.py", line 197 in run File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/support/__init__.py", line 1009 in _run_suite File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/support/__init__.py", line 1135 in run_unittest File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/libregrtest/runtest.py", line 273 in _test_module File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/libregrtest/runtest.py", line 309 in _runtest_inner2 File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/libregrtest/runtest.py", line 352 in _runtest_inner File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/libregrtest/runtest.py", line 227 in _runtest File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/libregrtest/runtest.py", line 257 in runtest File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/libregrtest/main.py", line 337 in rerun_failed_tests File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/libregrtest/main.py", line 715 in _main File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/libregrtest/main.py", line 658 in main File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/libregrtest/main.py", line 736 in main File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/__main__.py", line 2 in <module> File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/runpy.py", line 86 in _run_code File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/runpy.py", line 196 in _run_module_as_main 

tiran added a commit to tiran/cpython that referenced this pull request Dec 7, 2021
tiran added a commit to tiran/cpython that referenced this pull request Jun 26, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@tiran@bedevere-bot@ronaldoussoren@pablogsal@erlend-aasland@the-knights-who-say-ni