bpo-45893: Add missing extern C to initconfig.h (GH-29761)#29761
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Co-authored-by: Steve Dower <steve.dower@python.org>
gvanrossum approved these changes Nov 24, 2021
Member
gvanrossum left a comment
gvanrossum left a comment There was a problem hiding this comment.
What about Steve's other suggestion?
MemberAuthor
tiran commented Nov 24, 2021
Thanks for the ping. I missed his suggestion. I'll amend the PR. |
MemberAuthor
tiran commented Nov 24, 2021
GHA now has: |
tiran changed the title 
Contributor
miss-islington commented Nov 24, 2021
Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 24, 2021
Co-authored-by: Steve Dower <steve.dower@python.org> (cherry picked from commit f4afc53) Co-authored-by: Christian Heimes <christian@python.org>
bedevere-bot commented Nov 24, 2021
GH-29765 is a backport of this pull request to the 3.10 branch. |
miss-islington added a commit that referenced this pull request Nov 24, 2021
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
Co-authored-by: Steve Dower <steve.dower@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Steve Dower steve.dower@python.org
https://bugs.python.org/issue45893