Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 33.9k
bpo-45950: Introduce Bootstrap Python again#29859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
tiran commented Nov 30, 2021 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
bedevere-bot commented Nov 30, 2021
🤖 New build scheduled with the buildbot fleet by @tiran for commit b757d5bd526cfffeb134eb6744ac86c561e61e9d 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot commented Nov 30, 2021
🤖 New build scheduled with the buildbot fleet by @tiran for commit fa4cd7fc9f3763ff1309d8bfbc97853223f17239 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
gvanrossum commented Nov 30, 2021
Why not just always use |
vstinner commented Nov 30, 2021
When LTO is used, a link step can be quite slow. I noticed that when there was a second _bootstrap_python binary. I didn't check if _testembed has a similar issue or not. I'm mostly developing Python without |
vstinner commented Nov 30, 2021
Maybe LTO flags can be skipped on these less important binaries. |
vstinner commented Nov 30, 2021
FYI the revert #29717 fixed an issue with out of tree build. Please try to make sure that this bug is not reintroduced: https://bugs.python.org/issue45866#msg406764 |
tiran commented Dec 1, 2021 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
We need some extra logic in configure.ac and Makefile anyway. The
I'll come up with a better way to test |
757a652 to 551fb30Compare
gvanrossum left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am in favor of this. Thanks for doing this!
hroncok commented Dec 2, 2021
I'll try to build this as RPM in Fedora to see if there are some problems with our bootstrapped OOT build. |
hroncok commented Dec 2, 2021
I am getting a lot of undefined references to |
tiran commented Dec 2, 2021
Please try again. I have rebased the PR and added |
tiran commented Dec 2, 2021
OOT build with optimizations is passing for me on F35: |
bedevere-bot commented Dec 2, 2021
🤖 New build scheduled with the buildbot fleet by @tiran for commit 02da340e62db33a12aad1b03adf83a488e0255fb 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
hroncok commented Dec 2, 2021
That helped. |
tiran commented Dec 3, 2021
Rebased on top of #29902 |
The build system now uses a `_bootstrap_python` interpreter for freezing and deepfreezing again. Cross building depends on a build Python interpreter. `_bootstrap_python` and `_freeze_module` are no longer compiled with LTO. Link time optimization is very slow.
bedevere-bot commented Dec 3, 2021
@tiran: Please replace |
The build system now uses a :program:
_bootstrap_pythoninterpreter forfreezing and deepfreezing again. To speed up build process the build tools
:program:
_bootstrap_pythonand :program:_freeze_moduleare no longerbuild with LTO.
Cross building depends on a build Python interpreter, which must have same
version and bytecode as target host Python.
https://bugs.python.org/issue45950