Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
bpo-45774: Harden SQLite detection#30016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
erlend-aasland commented Dec 9, 2021 • edited by miss-islington
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by miss-islington
Uh oh!
There was an error while loading. Please reload this page.
- Beautify configure output - Make sure vital functions are in place
Uh oh!
There was an error while loading. Please reload this page.
Reindent contents of AC_ARG_ENABLE
bedevere-bot commented Dec 10, 2021
🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit f5b0552 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
erlend-aasland commented Dec 14, 2021 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Regarding the buildbot run: SQLite is correctly detected and the sqlite3 module is built, AFAICS. The two failures seem to be unrelated. |
erlend-aasland commented Dec 16, 2021
@tiran, are you ok with this PR? For those of us who've got multiple SQLite installations with completely different configurations, it's nice to fail early with |
erlend-aasland commented Jan 5, 2022
Regarding the buildbot run:
Both failures are unrelated to this PR. |
erlend-aasland commented Mar 2, 2022
@tiran: 🏓 |
gpshead left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm filing this one under Pedantically Correct. I'd not expect anyone to have an installed detectable sqlite3 ever built using various defines neutering the library. But if they do, this likely does a better job at detecting that and avoiding it.
bedevere-bot commented Mar 4, 2022
erlend-aasland commented Mar 4, 2022 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
I do, I do! ✋🏻 (Mostly for testing weird stuff like this) OTOH, we never know what kind of SQLite library will show up when we're running Python in the browser. |
bedevere-bot commented Apr 5, 2022
arhadthedev commented Apr 5, 2022
@tiran PPC64LE failure is sporadic, a rerun is required:
|
tiran commented Apr 5, 2022
The buildbot started to fail consistently two days ago. I have contacted Charris to look into the problem an hour ago. |
miss-islington commented Apr 5, 2022
@erlend-aasland: Status check is done, and it's a failure ❌ . |
16 similar comments
miss-islington commented Apr 5, 2022
@erlend-aasland: Status check is done, and it's a failure ❌ . |
miss-islington commented Apr 5, 2022
@erlend-aasland: Status check is done, and it's a failure ❌ . |
miss-islington commented Apr 5, 2022
@erlend-aasland: Status check is done, and it's a failure ❌ . |
miss-islington commented Apr 5, 2022
@erlend-aasland: Status check is done, and it's a failure ❌ . |
miss-islington commented Apr 5, 2022
@erlend-aasland: Status check is done, and it's a failure ❌ . |
miss-islington commented Apr 5, 2022
@erlend-aasland: Status check is done, and it's a failure ❌ . |
miss-islington commented Apr 5, 2022
@erlend-aasland: Status check is done, and it's a failure ❌ . |
miss-islington commented Apr 5, 2022
@erlend-aasland: Status check is done, and it's a failure ❌ . |
miss-islington commented Apr 5, 2022
@erlend-aasland: Status check is done, and it's a failure ❌ . |
miss-islington commented Apr 5, 2022
@erlend-aasland: Status check is done, and it's a failure ❌ . |
miss-islington commented Apr 5, 2022
@erlend-aasland: Status check is done, and it's a failure ❌ . |
miss-islington commented Apr 5, 2022
@erlend-aasland: Status check is done, and it's a failure ❌ . |
miss-islington commented Apr 5, 2022
@erlend-aasland: Status check is done, and it's a failure ❌ . |
miss-islington commented Apr 5, 2022
@erlend-aasland: Status check is done, and it's a failure ❌ . |
miss-islington commented Apr 5, 2022
@erlend-aasland: Status check is done, and it's a failure ❌ . |
miss-islington commented Apr 5, 2022
@erlend-aasland: Status check is done, and it's a failure ❌ . |
tiran commented Apr 5, 2022
The Windows refleak, PPC64LE, and s390x issues are unrelated to the PR. The s390x issue is addressed in GH-32332. |
https://bugs.python.org/issue45774
Automerge-Triggered-By: GH:tiran